Skip to content

Refactor menu, fix issues #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Refactor menu, fix issues #8

merged 3 commits into from
Mar 27, 2025

Conversation

pepelsbey
Copy link
Member

Description

  • Splits one long CSS file into multiple elements
  • Fixes issue with button icons
  • Simplifies theming for Learn, Tools, About sections
  • Updates icons and sets consistent sizes

@pepelsbey pepelsbey requested review from caugner and LeoMcA March 27, 2025 10:56
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a brief scan through: it's made me realise I don't really like BEM, but let's table that discussion for our CSS style discussion we're having next week.

Haven't run locally, but nothing major stands out in the code: ship it!

@pepelsbey pepelsbey merged commit 126e13d into mdn:main Mar 27, 2025
2 checks passed
@pepelsbey pepelsbey deleted the menu-refactor branch March 27, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants