fix(workflows/pr-test): do not use pull_request_target #25578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
system
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -42,12 +59,14 @@ | |||
| key: dotlocal-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-0 | |||
|
|
|||
| - name: Install Python poetry | |||
| uses: snok/install-poetry@v1 | |||
| if: env.HAS_ARTIFACT | |||
| uses: snok/[email protected] | |||
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Same approach as in the previous `pr-test` workflow in content: https://github.com/mdn/content/blob/e4a247688d05e26847527ce88434b3f53b47ad3f/.github/workflows/pr-test.yml
caugner
force-pushed
the
MP-1851-avoid-pull-request-target
branch
from
c3acec2 to
2b8d454
Compare
caugner
changed the title
argl
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the
pr-testworkflow frompull_request_targettopull_request.This was done for mdn/content in April 2024:
Motivation
Landing these changes separately should make the changes in http://github.com/mdn/translated-content/pull/25577 easier to review.
Additional details
Reference workflows:
Related issues and pull requests
Extracted from #25577.