Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflows/pr-test): do not use pull_request_target #25578

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 24, 2025

Description

Migrates the pr-test workflow from pull_request_target to pull_request.

This was done for mdn/content in April 2024:

Motivation

Landing these changes separately should make the changes in http://github.com/mdn/translated-content/pull/25577 easier to review.

Additional details

Reference workflows:

Related issues and pull requests

Extracted from #25577.

@caugner caugner requested a review from a team as a code owner January 24, 2025 13:01
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Jan 24, 2025
@@ -42,12 +59,14 @@
key: dotlocal-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-0

- name: Install Python poetry
uses: snok/install-poetry@v1
if: env.HAS_ARTIFACT
uses: snok/[email protected]

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'PR review companion' step
Uses Step
uses 'snok/install-poetry' with ref 'v1.4', not a pinned commit hash
@caugner caugner force-pushed the MP-1851-avoid-pull-request-target branch from c3acec2 to 2b8d454 Compare January 24, 2025 13:05
@caugner caugner changed the title refactor(workflows/pr-test): migrate from pull_request_target to pull_request event fix(workflows/pr-test): do not use pull_request_target Jan 24, 2025
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the codeql issues (that seem to be a false positive in our context) lgtm

@caugner caugner merged commit 6c72534 into main Jan 24, 2025
11 of 13 checks passed
@caugner caugner deleted the MP-1851-avoid-pull-request-target branch January 24, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants