Skip to content

Update for MV3 and Chrome compatibility #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dotproto
Copy link
Contributor

Updates the stored-credentials example to use Manifest V3 and to add support for Chrome. This demo now works in Firefox and Chrome. It does not work in Safari because at the moment webRequestAuthProvider is unsupported.

@rebloor
Copy link
Collaborator

rebloor commented Jul 22, 2024

@dotproto This change makes the example inconsistent with the guidance in the readme file: "These examples are tested in Firefox. They may work in other browsers, if the browser supports the APIs used. Note that these examples all use the browser namespace and promises to work with asynchronous functions. This means the examples won't work in Chrome unless you use the polyfill provided by Mozilla. See the overview of WebExtension APIs for more information."
I'm wondering whether we should continue with this as an MV2, Firefox-only example unless we have plans to update all the extensions to MV3 and Chrome support. We introduced an inconsistency and potentially an expectation of updates we may not have plans to make.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Aug 21, 2024
dotproto added 2 commits March 9, 2025 17:11
@rebloor [noted][1] that the root readme states that "examples are tested in Firefox." This change removes Chrome support in order to accurately reflect the framing established in the README.

[1]: #565 (comment)
@dotproto dotproto requested a review from rebloor March 10, 2025 00:14
@dotproto
Copy link
Contributor Author

That's a very good point. I've revised the demo to revert back to MV2 and to remove Chrome compatibility changes. While I do want to put concerted effort into updating the demos, we should stay consistent until we establish a plan and update the docs to reflect it.

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Mar 10, 2025
Copy link
Collaborator

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotproto sorry for the delay. I've left one small suggestion. I've also run the extension and confirmed that it behaves as expected.

for the demo site:
This add-on stores a username and password using the
[`storage.local`](https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/storage/local)
API. The default value is the correct value for the demo site:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
API. The default value is the correct value for the demo site:
API. The default values are the correct ones for the demo site:

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants