-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Update for MV3 and Chrome compatibility #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@dotproto This change makes the example inconsistent with the guidance in the readme file: "These examples are tested in Firefox. They may work in other browsers, if the browser supports the APIs used. Note that these examples all use the browser namespace and promises to work with asynchronous functions. This means the examples won't work in Chrome unless you use the polyfill provided by Mozilla. See the overview of WebExtension APIs for more information." |
@rebloor [noted][1] that the root readme states that "examples are tested in Firefox." This change removes Chrome support in order to accurately reflect the framing established in the README. [1]: #565 (comment)
That's a very good point. I've revised the demo to revert back to MV2 and to remove Chrome compatibility changes. While I do want to put concerted effort into updating the demos, we should stay consistent until we establish a plan and update the docs to reflect it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dotproto sorry for the delay. I've left one small suggestion. I've also run the extension and confirmed that it behaves as expected.
for the demo site: | ||
This add-on stores a username and password using the | ||
[`storage.local`](https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/storage/local) | ||
API. The default value is the correct value for the demo site: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API. The default value is the correct value for the demo site: | |
API. The default values are the correct ones for the demo site: |
Updates the stored-credentials example to use Manifest V3 and to add support for Chrome. This demo now works in Firefox and Chrome. It does not work in Safari because at the moment
webRequestAuthProvider
is unsupported.