fix(backend): intermittent login failure with google auth #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix intermittent login issues with google - modify sign in with google settings to use `redirect` ux mode - modify sign in with google settings to use fedCM - modify google auth stack to work around issues with safari
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
detj
changed the title
anupcowkur
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
The Google OAuth consent screen settings is configured in testing mode. This effectively means only login attempts from whitelisted Google accounts will succeed. We need to publish the OAuth app before launch, otherwise non-whitelisted users won't be able to login using Google.
Summary
Login with Google would fail intermittently on Chromium and repeatedly fail on Safari. In this PR, we turn on FedCM so that sign in with Google works on browsers that block third-party cookies. We also implement a bypass on nonce checking on Safari browsers while implementing logs for further monitoring this particular situation. Overall, authentication with Google should be more robust with this PR.
Tasks
redirectux modeReferences
For more context, see below.