Skip to content

feat(#9707): add nouveau to helm charts #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 9542_freetext_tco
Choose a base branch
from

Conversation

witash
Copy link
Contributor

@witash witash commented Jul 29, 2025

This adds a new pod and service for nouveau.

some notes:

  • it does not add a new volume for nouveau data, instead it uses the same volume that couchdb uses. Nouveau is supposed to be mostly transparent, essentially just a part of couchdb, so we don't want to ask deployers to provision space for a separate volume, the size of which will be unknown and difficult to estimate. Also the main point of nouveau is to reduce storage space, so we don't want to have to ask for more instead. For multi-node couchdb this is a little complicated, because of course each couch node has its own volume, but we don't want nouveau to duplicate nouveau data for each node. So one solution is to just use the volume from the first couchdb node. This means both the storage size and IO will be imbalanced; the first node will be larger and busier in terms of IO operations than other nodes. For now, I'm assuming that this won't significant, but its something we should verify somehow; is the performance of the first couchdb node going to be significantly worse because of the extra IO operations from nouveau?
  • For the nouveau instance it does add a new pod; if we really wanted to have all the resources for nouveau be combined with couchdb, we could add a nouveau container to each existing couchdb pod, instead of a new pod. This is also a change from the current performance; all freetext searches will use a single nouveau instance even if couchdb is clustered. We should also verify that that won't become a bottleneck, but it seems unlikely.
  • Its mounted on a hardcoded subdirectory and will ignore the settings for preexisting data. Which means nouveau indexes will have to rebuild after a new deployment even if using preexisting data, which is a change from previous behavior where views would come along with the other data. But I don't think its worth it to add new settings for nouveau data paths, which no one is going to know or want to care about.
  • I'm not sure what the tolerations are for, so I copied them from the couchdb template.

@witash witash changed the title 9707 add nouveau to helm charts feat(#9707): add nouveau to helm charts Jul 30, 2025
@witash witash marked this pull request as ready for review July 30, 2025 10:16
@witash witash requested review from lorerod and Hareet July 30, 2025 10:33
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ The nouveau Helm templates are properly integrated and pass all validation tests across all deployment scenarios. Thank you @witash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants