Skip to content

fix(#10183): needs_signoff string bug #10182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonathanbataire
Copy link
Contributor

@jonathanbataire jonathanbataire commented Jul 29, 2025

Description

Current implementation assumes that the report/doc value produced from the xlsform is type boolean true/false yet all values in the doc are string literals
As a result if(doc.fields.needs_signoff) will always be true as long as a key and value exists in the doc with no regards to the value.

changes

The change here is to handle the needs_signoff value as a string

Fixes #10183

Code review checklist

  • UI/UX backwards compatible: Test it works for the new design (enabled by default). And test it works in the old design, enable can_view_old_navigation permission to see the old design. Test it has appropriate design for RTL languages.
  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@jonathanbataire jonathanbataire changed the title bug: fix needs_signoff bug bug(#10183): fix needs_signoff bug Jul 29, 2025
@jonathanbataire jonathanbataire marked this pull request as ready for review July 29, 2025 12:17
@jonathanbataire jonathanbataire changed the title bug(#10183): fix needs_signoff bug fix(#10183): needs_signoff string bug Jul 29, 2025
@jonathanbataire jonathanbataire marked this pull request as draft July 29, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replication fails to filter out reports with needs_signoff set to false
1 participant