Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (cht-android/issues/310) enable nginx to serve android app links #8275

Closed
wants to merge 1 commit into from

Conversation

mrjones-plip
Copy link
Contributor

@mrjones-plip mrjones-plip commented May 26, 2023

Description

Initial PR to enable nginx container to serve static JSON files for android asset links:

See cht-android/issues/308

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@mrjones-plip
Copy link
Contributor Author

After chatting with @kennsippell - I think we should take a different approach for this. Instead of allowing nginx to directly serve up a static JSON file as done here, we should update CHT Conf to have an settings, mainly the app ID and cert hash, and then server this up at the right location (/.well-known/assetlinks.json). This latter approach allows all the CHT config to logically be stored in one place (app settings) and not have to worry about static files outside of the CHT purview.

Leaving this PR open and as is in case anyone wants to test.

@garethbowen
Copy link
Member

@mrjones-plip Can we close this PR now? Happy to keep the branch around for testing purposes just trying to clean up old PRs!

@mrjones-plip
Copy link
Contributor Author

agreed - thanks for the house cleaning Gareth! 🏠 🧽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants