-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#8204): Add feature to support adding phone number when registering patients #8369
Merged
Merged
Changes from 56 commits
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
13e3133
Added sms form in app settings, trigger in registration and unit test…
PrjShrestha 0db854d
Reverting registration.js tests
PrjShrestha 6ab0253
registration.js add phone number function added
PrjShrestha 439cb8b
Added phone_number parser using google lib and changed app settings t…
1184519
phone number length validation
61de363
Added support for phone number and concrete unit tests
0ffa8c8
Added add_age trigger as well as country code validadtion at registra…
4a89954
Added sms parser tests and registration.js phone number funciton
3977367
registration test for valid phone number
49086cf
added phone number and age adding code to addpatient funtion in regis…
PrjShrestha 86e53ed
registration unit tests
PrjShrestha ae62cc2
added unit test to test that patient isn't created when phone is wrong
PrjShrestha 0185462
removed debugger and console.log
PrjShrestha 614a763
eslint issue fixes 1
PrjShrestha ad94523
eslint Fixes 2
PrjShrestha e2fa163
confirming to eslint standards to pass build
PrjShrestha 3e607ed
ident fix
PrjShrestha 2639a19
Reverted app settigns added phone duplicate turn of on on appsettings.
PrjShrestha 5a447b7
registration.js false positive and negative fix
PrjShrestha 08f7158
added duplicate phone optional logic and changed phone number to norm…
PrjShrestha 4cef416
"making double quotes to single quote from from-definition"
PrjShrestha b2e617c
unique phone check in both registration and validation.js
PrjShrestha db5b54c
Fixed validation.js function
PrjShrestha 1abff00
Doing validation for unique in before transition is run
PrjShrestha 3eb6a9d
added tests for unique phone validation
PrjShrestha 1480334
eslint fixes
PrjShrestha e7a2e66
Changes to smsparser after reading form from form definitions
PrjShrestha 495a874
Added translations and dynamic error messaging tried to fix registrat…
PrjShrestha 551c4a2
Removing it.only
PrjShrestha 9c59f40
Update tests/integration/sentinel/transitions/registration.spec.js
1yuv 4ce8a19
code reivew changes mainly translations
PrjShrestha 72ec2f0
Merge branch '8204' of https://github.com/PrjShrestha/cht-core into 8204
PrjShrestha ef55ff5
code review changes
PrjShrestha 12c59de
Apply suggestions from code review
1yuv 222cafa
Code reivew changes
PrjShrestha a544cf6
Merge branch '8204' of https://github.com/PrjShrestha/cht-core into 8204
PrjShrestha 82c9b7d
renamed file test-stubs and changed references
PrjShrestha b4894fa
Merge branch 'master' into 8204
PrjShrestha 4d629cc
Update shared-libs/transitions/src/transitions/registration.js Camel …
PrjShrestha 1ec2430
Code review changes
PrjShrestha 8c79231
Merge branch 'master' into 8204
PrjShrestha 95374aa
eslint fixes
PrjShrestha 46a4f2a
Code reivew changes form-definitions and code comments
PrjShrestha a4b55af
passed invalid phone number form sms parser and added valid phone val…
PrjShrestha b5378f4
phone validation in add_patient itself
PrjShrestha a88e85b
Implemented suggestion to remove add_phone_number trigger and do the …
PrjShrestha 807caf4
Changed sms parser tests and made sms parser return invalid number in…
PrjShrestha 1bf6514
added null checks on getpatientphonefield function
PrjShrestha 3f35ad1
added null check on formdef
PrjShrestha 85d2065
Checking if updated config fixes problem, cannot run unit tests locally
PrjShrestha 470601c
Apply suggestions from Diana's code review
PrjShrestha 7f266e2
code review changes
PrjShrestha 5123c8a
added null checks to see if it passes tests
PrjShrestha f076a63
Added tests to test add_patient trigger changes
PrjShrestha 325efed
Code review feedbacks and added unit test for getphonefield function …
PrjShrestha c05ab7a
Upgraded eslint versoin to ecma for optional chaining support, added …
PrjShrestha e06fbe9
Merge branch 'master' into 8204
PrjShrestha 45d74b5
Resolve commit
PrjShrestha c5eacaf
Aded nepali phone number support
PrjShrestha 49a05b3
used const value instead or reading from object
PrjShrestha 9e3116f
Adding comment to trigger build run
PrjShrestha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PrjShrestha , would you mind adding Nepali digit supporting code for this type as well? Here's the sample PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done