Support hcp upgrade

[mshitrit]

Why we need this PR

This feature aims to address the current limitations of NodeHealthCheck (NHC) in Hosted Control Planes (HCP). While NHC is operational in HCP, it lacks the ability to block or pause upgrades when nodes are unhealthy.

Changes made

In addition to previous checks, NHC will also compare "machineconfiguration.openshift.io/currentConfig" and "machineconfiguration.openshift.io/desiredConfig" on the CP node to decide whether an update is in progress.

Which issue(s) this PR fixes

OCPSTRAT-1828, RHWA-11

Test plan

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mshitrit]

/tests ?

[mshitrit]

/test ?

[openshift-ci]

@mshitrit: The following commands are available to trigger required jobs:

/test 4.14-ci-bundle-my-bundle

/test 4.14-images

/test 4.14-openshift-e2e

/test 4.14-test

/test 4.15-ci-bundle-my-bundle

/test 4.15-images

/test 4.15-openshift-e2e

/test 4.15-test

/test 4.16-ci-bundle-my-bundle

/test 4.16-images

/test 4.16-openshift-e2e

/test 4.16-test

/test 4.17-ci-bundle-my-bundle

/test 4.17-images

/test 4.17-openshift-e2e

/test 4.17-test

/test 4.18-ci-bundle-my-bundle

/test 4.18-images

/test 4.18-openshift-e2e

/test 4.18-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mshitrit]

/test 4.17-openshift-e2e

[mshitrit]

/test 4.17-openshift-e2e

[mshitrit]

/test 4.16-openshift-e2e

[mshitrit]

/test 4.16-openshift-e2e

[slintes]

one nit, otherwise lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mshitrit,slintes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mshitrit]

/test 4.16-openshift-e2e

[mshitrit]

/test 4.16-openshift-e2e

[mshitrit]

Testing after ocp testplatform team analyzed the issue and added a gpu

/test 4.16-openshift-e2e

[mshitrit]

Tests are failing due to ECOPROJECT-2187

/override ci/prow/4.15-openshift-e2e
/override ci/prow/4.16-openshift-e2e
/override ci/prow/4.17-openshift-e2e
/override ci/prow/4.18-openshift-e2e

[openshift-ci]

@mshitrit: Overrode contexts on behalf of mshitrit: ci/prow/4.15-openshift-e2e, ci/prow/4.16-openshift-e2e, ci/prow/4.17-openshift-e2e, ci/prow/4.18-openshift-e2e

In response to this:

Tests are failing due to ECOPROJECT-2187

/override ci/prow/4.15-openshift-e2e
/override ci/prow/4.16-openshift-e2e
/override ci/prow/4.17-openshift-e2e
/override ci/prow/4.18-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mshitrit]

/override ci/prow/4.14-openshift-e2e

[openshift-ci]

@mshitrit: Overrode contexts on behalf of mshitrit: ci/prow/4.14-openshift-e2e

In response to this:

/override ci/prow/4.14-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.