Skip to content

[WIP] ECOPROJECT-2560: Migrate to PF5 and use newer dynamic plugin SDK #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

rawagner
Copy link
Contributor

@rawagner rawagner commented Jan 22, 2025

Why we need this PR

OCP 4.19 removes support for PF4, only PF5 is supported

Changes made

Migrated PF4 components to PF5

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-2560

Test plan

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2025

@rawagner: This pull request references ECOPROJECT-2560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Why we need this PR

OCP 4.17 removes support for PF4, only PF5 is supported

Changes made

Migrated PF4 components to PF5

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-2560

Test plan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@slintes
Copy link
Member

slintes commented Jan 22, 2025

just to be sure, since when is PF5 supported? We currently release to OCP 4.14+ :)

@rawagner
Copy link
Contributor Author

rawagner commented Jan 22, 2025

just to be sure, since when is PF5 supported? We currently release to OCP 4.14+ :)

support for PF5 was added in OCP 4.15

< 4.15 => only PF4

4.15 - 4.18 => both PF4 and PF5 can be used

> 4.18 => only PF5

@slintes
Copy link
Member

slintes commented Jan 22, 2025

I guess that's an issue... 🤔

What is not working on 4.17+ with PF4?

@rawagner
Copy link
Contributor Author

I guess that's an issue... 🤔

What is not working on 4.17+ with PF4?

sorry, my bad. I've updated the previous comment with correct versions.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2025

@rawagner: This pull request references ECOPROJECT-2560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Why we need this PR

OCP 4.19 removes support for PF4, only PF5 is supported

Changes made

Migrated PF4 components to PF5

Which issue(s) this PR fixes

https://issues.redhat.com/browse/ECOPROJECT-2560

Test plan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: batzionb, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@batzionb
Copy link
Contributor

batzionb commented May 6, 2025

/approved

@batzionb batzionb merged commit f3626da into medik8s:main May 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants