Implement FHIR Async Request Pattern for Direct Broker using CQL #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmteZogaf
force-pushed
the
feature/530-add-async-execution-direct-broker
branch
2 times, most recently
from
d4ec6b4 to
4890e23
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #539 +/- ##
=============================================
+ Coverage 79.29% 80.05% +0.76%
- Complexity 690 727 +37
=============================================
Files 163 166 +3
Lines 2932 3044 +112
Branches 291 299 +8
=============================================
+ Hits 2325 2437 +112
Misses 487 487
Partials 120 120 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/de/numcodex/feasibility_gui_backend/query/broker/direct/AsyncRequestExecutor.java
Fixed
Show resolved
Hide resolved
EmteZogaf
force-pushed
the
feature/530-add-async-execution-direct-broker
branch
from
4890e23 to
233cb5e
Compare
src/test/java/de/numcodex/feasibility_gui_backend/query/broker/direct/DirectSpringConfigIT.java
Fixed
Show fixed
Hide fixed
EmteZogaf
force-pushed
the
feature/530-add-async-execution-direct-broker
branch
3 times, most recently
from
0f4a8ad to
b685c05
Compare
Added configuration property `broker.direct.cql.useAsyncRequestPattern` with default value true to support asynchronous request handling when the Direct Broker is using CQL queries. This enhancement improves performance by allowing non-blocking request processing, particularly useful for complex or long-running CQL queries. The change is part of the broker client configuration and can be controlled via the environment variable `BROKER_CLIENT_DIRECT_CQL_USE_ASYNC_REQUEST_PATTERN` when needed.
Increase time interval to test timeout against.
EmteZogaf
force-pushed
the
feature/530-add-async-execution-direct-broker
branch
from
b685c05 to
f84866e
Compare
michael-82
approved these changes
Jul 2, 2025
| @@ -88,6 +88,8 @@ app: | |||
| secret: ${BROKER_CLIENT_DIRECT_AUTH_OAUTH_CLIENT_SECRET:} | |||
| enabled: ${BROKER_CLIENT_DIRECT_ENABLED:false} | |||
| useCql: ${BROKER_CLIENT_DIRECT_USE_CQL:false} | |||
| cql: | |||
| useAsyncRequestPattern: ${BROKER_CLIENT_DIRECT_CQL_USE_ASYNC:false} | |||
There was a problem hiding this comment.
I'll probably move this parameter to another place in a separate issue/pr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration property
broker.direct.cql.useAsyncRequestPatternwith default value false to support asynchronous request handling when the Direct Broker is using CQL queries. This enhancement improves performance by allowing non-blocking request processing, particularly useful for complex or long-running CQL queries.The change is part of the broker client configuration and can be controlled via the environment variable
BROKER_CLIENT_DIRECT_CQL_USE_ASYNC_REQUEST_PATTERNwhen needed and defaults tofalsefor staying compatible with deployments using HAPI based CQL-enabled FHIR servers which reject requests with unknown headers.