#689 - Improved error handling #717
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace webflux call to post feasibility query with a "regular" one - extend the StructuredQueryValidator for posted ccdls to contain the same checks as the validate endpoint has - add a RestControllerAdvice class to the FeasibilityQueryHandlerRestController that extracts the validator errors and returns them
- add check for invalid value filters
- switch to newer json schema library
- add skeleton for DataExtraction Validation - small changes to json schemas (this has to be double checked some time...) - add more path info in QueryHandlerRestControllerAdvice - add validate endpoint for crtdl (requires DataExtraction Validation to actually do something)
- begin with dataExtraction validation
- implement most of the data extraction validation. 2 items missing
- finish DataExtractionValidator function - tests still missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This requires ontology 3.10.0, which is (as of 2025-10-30) not yet released