Skip to content

Conversation

@paulolaup
Copy link
Collaborator

@paulolaup paulolaup commented Aug 7, 2025

Add element availability measure generation

Closes: #320

@paulolaup paulolaup self-assigned this Aug 7, 2025
@paulolaup paulolaup added the availability Impacts the availability generation label Aug 7, 2025
@paulolaup paulolaup linked an issue Aug 7, 2025 that may be closed by this pull request
@paulolaup paulolaup changed the title SQUASH ME Create broad availability measure Aug 10, 2025
@paulolaup paulolaup changed the title Create broad availability measure 320 create broad availability measure Aug 10, 2025
@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 3 times, most recently from a064aba to c260c35 Compare August 22, 2025 16:37
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 58.16327% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.37%. Comparing base (9b7657c) to head (f59e203).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
common/util/project/__init__.py 46.93% 23 Missing and 3 partials ⚠️
common/model/fhir/structure_definition.py 56.52% 20 Missing ⚠️
common/util/log/formatters.py 65.62% 7 Missing and 4 partials ⚠️
common/util/http/exceptions.py 16.66% 10 Missing ⚠️
common/util/http/client.py 27.27% 8 Missing ⚠️
common/util/fhir/package/manager.py 33.33% 4 Missing ⚠️
tests/integration/conftest.py 50.00% 2 Missing ⚠️
common/util/codec/json.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
- Coverage   57.30%   53.37%   -3.94%     
==========================================
  Files          45       21      -24     
  Lines        3574     1083    -2491     
  Branches      517      132     -385     
==========================================
- Hits         2048      578    -1470     
+ Misses       1396      481     -915     
+ Partials      130       24     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 2 times, most recently from 234905d to 095608e Compare August 28, 2025 22:12
@pytest.fixture
def profile(request, package_manager: FhirPackageManager):
"""
Fixture that resolve can be used for indirect parameters named 'profile' to resolve any `string` typed value as a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the first 'resolve' meant to be there? typo?

@pytest.fixture
def elem_def(request, profile):
"""
Fixture that resolve can be used for indirect parameters named 'elem_def' to resolve any `string` typed value as a
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. is 'resolve' a typo`?

project: fdpg-availability

run_unit_tests:
needs: build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the dependency on the build step? Since unit tests should not depend on the script output, they could run in parallel with the build, saving developer waiting time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 16 times, most recently from 26636a1 to 659d1a7 Compare September 2, 2025 13:46
@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 5 times, most recently from af94077 to 7cb16af Compare September 26, 2025 08:58
Copy link
Collaborator

@Frontman50 Frontman50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review failing checks. Also code coverage dropped by 4.54%

@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 7 times, most recently from 78e5a90 to f76eccc Compare October 7, 2025 08:49
@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 8 times, most recently from 947b97c to 00f7e48 Compare October 8, 2025 16:11
@paulolaup paulolaup requested a review from Frontman50 October 23, 2025 13:23
@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch 2 times, most recently from 1456647 to 47b2da2 Compare October 30, 2025 15:12
Availability:
  Element Availability Generation:
    - Add and update related utilities
    - Add unit and integration tests
  DSE Element Availability Generation:
    - Add generation script
    - Integrate generation into workflow

Common:
  - Add utilities for FHIR package management

Projects:
  FDPG Ontology:
    - Update package requirements to align with package provided by repository

General:
  - Fix bugs

CI:
  - Add job running unit test
  run-integration-tests:
    - Add log file artifact upload
  release-ci:
    - Align structure to run-tests workflow to improve runtime

Logging:
  - Change logging file type and update content
  - Add file logging at DEBUG level

Projects:
  FDPG Ontology:
    - Update package requirements to align with package provided by repository
@paulolaup paulolaup force-pushed the 320-create-broad-availability-measure branch from 47b2da2 to e7b6422 Compare October 30, 2025 15:50
@paulolaup paulolaup enabled auto-merge October 30, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

availability Impacts the availability generation ci/cd tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Broad CDS Analysis Measure

4 participants