-
Notifications
You must be signed in to change notification settings - Fork 3
320 create broad availability measure #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a064aba to
c260c35
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
==========================================
- Coverage 57.30% 53.37% -3.94%
==========================================
Files 45 21 -24
Lines 3574 1083 -2491
Branches 517 132 -385
==========================================
- Hits 2048 578 -1470
+ Misses 1396 481 -915
+ Partials 130 24 -106 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
234905d to
095608e
Compare
tests/unit/availability/conftest.py
Outdated
| @pytest.fixture | ||
| def profile(request, package_manager: FhirPackageManager): | ||
| """ | ||
| Fixture that resolve can be used for indirect parameters named 'profile' to resolve any `string` typed value as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the first 'resolve' meant to be there? typo?
tests/unit/availability/conftest.py
Outdated
| @pytest.fixture | ||
| def elem_def(request, profile): | ||
| """ | ||
| Fixture that resolve can be used for indirect parameters named 'elem_def' to resolve any `string` typed value as a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here. is 'resolve' a typo`?
.github/workflows/run-tests.yml
Outdated
| project: fdpg-availability | ||
|
|
||
| run_unit_tests: | ||
| needs: build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the dependency on the build step? Since unit tests should not depend on the script output, they could run in parallel with the build, saving developer waiting time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
26636a1 to
659d1a7
Compare
af94077 to
7cb16af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review failing checks. Also code coverage dropped by 4.54%
78e5a90 to
f76eccc
Compare
947b97c to
00f7e48
Compare
1456647 to
47b2da2
Compare
Availability:
Element Availability Generation:
- Add and update related utilities
- Add unit and integration tests
DSE Element Availability Generation:
- Add generation script
- Integrate generation into workflow
Common:
- Add utilities for FHIR package management
Projects:
FDPG Ontology:
- Update package requirements to align with package provided by repository
General:
- Fix bugs
CI:
- Add job running unit test
run-integration-tests:
- Add log file artifact upload
release-ci:
- Align structure to run-tests workflow to improve runtime
Logging:
- Change logging file type and update content
- Add file logging at DEBUG level
Projects:
FDPG Ontology:
- Update package requirements to align with package provided by repository
47b2da2 to
e7b6422
Compare
Add element availability measure generation
Closes: #320