Fix performance of descendant count determination #379
+632
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulolaup
requested review from
Frontman50 and
juliangruendner
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 61.48% 62.07% +0.59%
==========================================
Files 47 48 +1
Lines 3692 3726 +34
Branches 529 534 +5
==========================================
+ Hits 2270 2313 +43
+ Misses 1276 1266 -10
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Changes improve performance for large code systems as tested by @BoehmDo |
paulolaup
force-pushed
the
378-improve-performance-of-descendant-determination
branch
2 times, most recently
from
393713f to
7698bd8
Compare
paulolaup
force-pushed
the
378-improve-performance-of-descendant-determination
branch
from
7698bd8 to
7aa0e13
Compare
Cohort Selection Ontology:
- Fix performance of descendant count determination
by implementing storage and lookup of intermediate
results
CI/CD:
- Add steps/jobs for running unit tests
Tests:
- Add unit test for descendant calculation
paulolaup
force-pushed
the
378-improve-performance-of-descendant-determination
branch
from
7aa0e13 to
ceed37e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cohort Selection Ontology:
Closes: #378