feat(core-flows, promotion): limit promotion use per promo code #13693
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 8 Skipped Deployments
|
| "title": "Usage", | ||
| "description": "Set a limit on how many times the promotion can be used." | ||
| }, | ||
| "use_by_attribute": { |
There was a problem hiding this comment.
EDIT: some properties are snake and others are camel... huh haha
There was a problem hiding this comment.
good point, will fix that
| ? t("campaigns.budget.fields.limitBudgetAttributeCustomer") | ||
| : t("campaigns.budget.fields.limitBudgetAttributeEmail") | ||
| ? t("campaigns.budget.fields.totalUsedByAttribute", { | ||
| attribute: campaign.budget?.attribute, |
There was a problem hiding this comment.
The attribute here will always be in English even if we get the translation from another language right?
There was a problem hiding this comment.
it is the name of the attribute, it can be anything user defines in theory
| const attributeValue = ( | ||
| attribute === "promotion_code" | ||
| ? registrationContext[attribute] | ||
| : promotion.code | ||
| ) as string | null |
There was a problem hiding this comment.
thought: Tbh. I am not a huge fan of this; it feels dirty to have hard-coded exceptions like this in the code.
I think we should consider adding a limit directly on the promotion as an alternative solution. That limit could be combined with a campaign budget to solve this use case.
I am curious to hear what you and others think @medusajs/os
There was a problem hiding this comment.
For context, the use case we are trying to solve here is:
Some of our users would like to create a single campaign called Customer Service Promos under which their team can create one-time promotions for individual customers. However, the current implementation prevents this because the limit applies at the campaign level rather than per promotion. They are once again left with creating a new campaign for recurring customers (i.e. customers that have already received a code from the campaign in the past).
There was a problem hiding this comment.
Yeah wasn't happy with that either.
Wdyt about modifying CampaignBudgetUsageContext to have scopes that are applied per promotion, for example:
export type CampaignBudgetUsageContext = {
/** applied on all promotions **/
customer_id: string | null
customer_email: string | null
/** applied only on matching promotions **/
promotions_context: {
[promo_id]: {
code: string | null
}
}
}
Then, when we iterate over promotions when computing actions or registering usage, we merge the context that is scoped for that promotion?
fPolic
force-pushed
the
feat/limit-promotion-promo-code
branch
from
6653df7 to
cf767f1
Compare
fPolic
changed the base branch from
feat/limit-promotion-per-customer-data-model
to
develop
fPolic
force-pushed
the
feat/limit-promotion-promo-code
branch
from
cf767f1 to
2c5985a
Compare
fPolic
changed the title
3 participants
What