-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(order,dashboard): version order credit lines #13766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willbouch
wants to merge
5
commits into
develop
Choose a base branch
from
feat/version-credit-lines
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+497
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0ecb6de The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
7 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What — What changes are introduced in this PR?
Added
version
to the already credit line entityWhy — Why are these changes relevant or necessary?
When issuing an Ad Hoc refund, we systematically create a credit line of the same value to balance out the order total. However, if something goes wrong in the workflow, there was no way to really revert the edits to the order because credit lines did not have version.
Testing — How have these changes been tested, or how can the reviewer test the feature?
The revert flow is pretty thoroughly tested I noticed so I mostly tested manually. I confirmed that before, the credit lines were not reverted in case of an error and now it does.
Checklist
Please ensure the following before requesting a review:
yarn changeset
and follow the prompts