-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(dashboard): settingsRoutes list error #14461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 6786da5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 76 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@chuxi is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
tested on my local environment |
|
@adrien2p can you help review this pr and merge the code? Thanks. |
|
hey @chuxi thanks for the contribution, can I get you to add a changeset please |
fbe4e3d to
b962def
Compare
yes. just added. |
|
@adrien2p hello, please help review this pr? thanks. |
|
@chuxi I already reviewed it, now I am just waiting for another approval (cc @olivermrbl ) |
Summary
What — What changes are introduced in this PR?
This pull request makes a small change to how settings routes are merged in the route map. It updates the code to flatten and include all children from each route in
settingsRoutes, rather than just the first one.fix #13970
Note
Ensures all plugin settings pages appear in the dashboard.
...(settingsRoutes?.[0]?.children || [])with...(settingsRoutes.flatMap(r => r?.children || []))inget-route.map.tsxto include children from every entry insettingsRoutes@medusajs/dashboardWritten by Cursor Bugbot for commit 6786da5. This will update automatically on new commits. Configure here.