-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(types,utils): pluralization for compound words ending in uncountable word #14485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix(types,utils): pluralization for compound words ending in uncountable word #14485
Conversation
…ypying. Match also words ending in uncountable words with regex
🦋 Changeset detectedLatest commit: 2178e6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 76 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 8 Skipped Deployments
|
|
ping, should we proceed? |
|
there is a typo in the filename should we aim to have all these types autogenerated, like we have for the module's methods? that way we have aligned the method name and the types |
do you mean the module services? we could but then you wont have them during the implementation, only after building and in the core we would not have them at all right? |
We keep this one as is, mostly for the core. But for a Medusa project it will override these with the auto generated. Which is fine as it only requires a |
yes we could imagine both and run |
Summary
What — What changes are introduced in this PR?
Fix pluralization for compound words ending in an uncountable word and make the runtime pluralization exactly match the typing pluralization in terms of uncountable words. Make both forms of pluralization share a single source of truth in terms of what we consider uncountable words.
Why — Why are these changes relevant or necessary?
We had a few issues:
infowordHow — How have these changes been implemented?
Testing — How have these changes been tested, or how can the reviewer test the feature?
Please provide answer here
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
// Example usageChecklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
fixes #14328