-
-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(admin): Fix table cell stacking in RTL languages #14568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
fix(admin): Fix table cell stacking in RTL languages #14568
Conversation
Replace 'left-[68px]' with 'start-[68px]' in data table sticky cells to properly support RTL languages. The 'start-*' utility automatically adapts to text direction (left in LTR, right in RTL), preventing table cells from stacking and hiding checkboxes in Hebrew and other RTL languages. Fixes medusajs#14489
🦋 Changeset detectedLatest commit: 39a1eaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 76 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@iharshyadav is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
@NicolasGorga please review my pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
packages/admin/dashboard/src/components/table/data-table/data-table-root/data-table-root.tsx
Show resolved
Hide resolved
Update sticky positioning to use start-0 instead of left-0 to prevent CSS conflicts in RTL mode. Previously, start-[68px] would become right: 68px while left-0 remained, causing both properties to apply simultaneously.
NicolasGorga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@NicolasGorga i have done the changes which you told please review. |
|
@fPolic can you please review my pr if possible. |
fPolic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the contribution @iharshyadav
|
@fPolic its good to hear, can i know when it will me merged, it would be grateful. |
Replace 'left-[68px]' with 'start-[68px]' in data table sticky cells to properly support RTL languages
The 'start-*' utility automatically adapts to text direction (left in LTR, right in RTL), preventing table cells from stacking and hiding checkboxes in Hebrew and other RTL languages.
Fixes #14489
Summary
What — What changes are introduced in this PR?
Changed the CSS positioning utility from
left-[68px]tostart-[68px]in two locations within the data table component for sticky header and body cells.Why — Why are these changes relevant or necessary?
In RTL (Right-to-Left) languages like Hebrew and Arabic, the admin dashboard's data tables were displaying incorrectly. Table cells with checkboxes were stacking on top of each other, making checkboxes invisible in the Fulfillment Providers section (Settings → Locations & Shipping → Edit Fulfillment Providers). This prevented users from selecting providers in RTL language mode.
How — How have these changes been implemented?
Replaced the absolute positioning class
left-[68px]with the logical propertystart-[68px]in thedata-table-root.tsxcomponent. Tailwind'sstart-*utility is a logical property that automatically becomesleft-*in LTR languages andright-*in RTL languages, ensuring proper layout in both text directions.Testing — How have these changes been tested, or how can the reviewer test the feature?
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
Visual comparison:
start-[68px]→left: 68px✅start-[68px]→right: 68px✅Checklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
start-*Tailwind utility is a standard logical property supported in all modern browsersNote
Ensures sticky table header and first-column cells position correctly in RTL.
data-table-root.tsx, replaceleft-0/left-[68px]withstart-0/start-[68px]for sticky header and body cellsrtl-table-start-68px.mdfor@medusajs/dashboardpatch releaseWritten by Cursor Bugbot for commit 39a1eaf. This will update automatically on new commits. Configure here.