fix(core-flows): force cart refresh on updatePromotionsWorkflow when refreshing items #14569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What — What changes are introduced in this PR?
Guarantee that
updateCartPromotionsWorkflowhas the latest snapshot of the cart.Why — Why are these changes relevant or necessary?
We were avoiding refetching the cart in
updateCartPromotionsWorkflow, which doesn't cause issues unless:item_subtotal >= 100.In this case, if we don't force the refresh inside the workflow,
refreshCartShippingMethodsWorkflowruns and updates the shipping totals correctly, but we pass a cart object with stale data for the shipping totals and thus, adding/removing an item from the cart will compute the promotion based on the shipping total before the modification happened.How — How have these changes been implemented?
Force the cart to be refreshed inside
updateCartPromotionsWorkflowso that if the shipping total changed because it had a calculated price dependent on the cart context, then the promotion is computed using the latest information of the cart.Testing — How have these changes been tested, or how can the reviewer test the feature?
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
// Example usageChecklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Add any additional context, related issues, or references that might help the reviewer understand this PR.
fixes #14484
Note
Ensures promotions are computed against the latest cart state when items change, avoiding stale shipping totals.
refresh-cart-items.ts, remove passingcarttoupdateCartPromotionsWorkflow, forcing it to refetch the cart before applyingREPLACEonpromo_codes.@medusajs/core-flows.Written by Cursor Bugbot for commit 937ae7a. This will update automatically on new commits. Configure here.