Draft
Conversation
size-limit report 📦
|
meduzen
force-pushed
the
datetime-getnormalizedday
branch
4 times, most recently
from
c9dee7a to
7519848
Compare
meduzen
force-pushed
the
datetime-getnormalizedday
branch
from
7519848 to
fc86a2c
Compare
meduzen
commented
Jul 23, 2024
| * | ||
| * @returns {number} | ||
| */ | ||
| getNormalisedDay = () => getNormalizeDay(this) |
Owner
Author
There was a problem hiding this comment.
Should be getNormalizedDay with a z instead of a s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built upon #132. Set as draft until #132 is merged.
As it’s centered around the idea that a week starts on Monday, check if it needs a setting defining the first day of the week.
Missing:
getNormalizedMonth())?DateTime.getNormalizedDay)