-
-
Notifications
You must be signed in to change notification settings - Fork 398
added return to previous directory before cleanup call #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
That's not the "previous" directory. That's the parent directory. You can change to the previous directory by
-- https://pubs.opengroup.org/onlinepubs/9699919799/utilities/cd.html |
|
It might be a good idea to add a unit test for the cleanup script too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| fi | ||
| fi | ||
| cd ".." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Cleanup Command Navigates Incorrectly
The cd ".." command added before MS_exec_cleanup aims to return to the previous directory, but it actually navigates to the parent directory. This difference can cause the cleanup process to run from an incorrect location, particularly if $tmpdir isn't a direct child of the original working directory or if $tmpdir is the current directory.
#310 (comment)
Note
Insert
cd ".."beforeMS_exec_cleanupso the script returns to the parent directory prior to cleanup and exit.Written by Cursor Bugbot for commit 53acbf2. This will update automatically on new commits. Configure here.