Fix 3D to 2D phase reconstruction#441
Merged
talonchandler merged 48 commits intomainfrom May 22, 2025
Merged
Conversation
Contributor
Does this mean that this method will be very sensitive to tilted sample? @ahillsley can confirm but I recall seeing some variation of focus within FOVs. Maybe they will need tiling here? |
Collaborator
Author
Very possible. On our first few iterations we should definitely keep an eye on our reconstruction quality that varies with focus across the FOV. |
…een QC'd with real data
…rt_phase_contrast` correctly
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
ziw-liu
reviewed
May 22, 2025
|
|
||
| Examples | ||
| -------- | ||
| >>> _position_list_from_shape_scale_offset(5, 1.0, 0.0) |
Contributor
There was a problem hiding this comment.
Can this be moved to tests? We don't have doctest set up.
Contributor
ziw-liu
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes ##172. Moved from old recOrder draft PR.
This PR fixes the 3D to 2D phase reconstruction, best demonstrated in this video with OPS006 data:
Screen.Recording.2025-05-07.at.5.38.07.PM.mov
The key fixes were:
waveorderframework. This allowed me to debug with easier math.While debugging I made two observations:
z_focus_offsetparameter.TODO:
save absorption to the output zarr, with correct channel names. I'm estimating absorption, just not saving it for nowskipped for now...will reevaluate after testing with absorbing sample.Paths:
/hpc/projects/comp.micro/microscope_dev/2025-3d-to-2d-debug/2025-05-07-3d-to-2d-debug/visualize.pywill open napari like in the viewer above