-
Notifications
You must be signed in to change notification settings - Fork 6
Fix 3D to 2D phase reconstruction #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this mean that this method will be very sensitive to tilted sample? @ahillsley can confirm but I recall seeing some variation of focus within FOVs. Maybe they will need tiling here? |
Very possible. On our first few iterations we should definitely keep an eye on our reconstruction quality that varies with focus across the FOV. |
…een QC'd with real data
…rt_phase_contrast` correctly
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
Co-authored-by: Ziwen Liu <[email protected]>
|
||
Examples | ||
-------- | ||
>>> _position_list_from_shape_scale_offset(5, 1.0, 0.0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved to tests? We don't have doctest set up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Fixes ##172. Moved from old recOrder draft PR.
This PR fixes the 3D to 2D phase reconstruction, best demonstrated in this video with OPS006 data:
Screen.Recording.2025-05-07.at.5.38.07.PM.mov
The key fixes were:
waveorder
framework. This allowed me to debug with easier math.While debugging I made two observations:
z_focus_offset
parameter.TODO:
save absorption to the output zarr, with correct channel names. I'm estimating absorption, just not saving it for nowskipped for now...will reevaluate after testing with absorbing sample.Paths:
/hpc/projects/comp.micro/microscope_dev/2025-3d-to-2d-debug/2025-05-07-3d-to-2d-debug/visualize.py
will open napari like in the viewer above