close response body #31
Conversation
| // Create json for request | ||
| json, err := json.Marshal(volume.Request{}) | ||
| // Create json for request - local variable json masks the global symbol json referring to the JSON module | ||
| jsn, err := json.Marshal(volume.Request{}) |
There was a problem hiding this comment.
Was this intentional? Probably should leave it as json
There was a problem hiding this comment.
I think json is a package name
There was a problem hiding this comment.
ah, yes that makes sense
I wonder how this didn't cause problems before in our testing?
|
I'm a bit confused what the patch is for. Did we fail to close the response body in the server? If so, perhaps we should change non-tests too? |
|
I was going based off of the comment |
No description provided.