Change receiving #44
Merged
Change receiving #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2024
Co-authored-by: Mateusz Front <[email protected]>
Noarkhh
force-pushed
the
change-receiving
branch
from
3facfe0 to
1254276
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR which removes the need for
_no_responsefunctions.Now, after transferring the socket control from the RTSP session to the TCP Source, the session changes it's behavior. After sending a request, rather than trying to receive the response from the socket, it will invoke a
receive doto receive the response from another process. The response still needs to be supplied.The reasoning for this change is that when the session doesn't control the socket trying to receive from it could cause unintended behavior, like race conditions.
This PR also introduces retrying on 401 responses