Skip to content

Bump version for memgraph 3.2.1 #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2025
Merged

Bump version for memgraph 3.2.1 #143

merged 3 commits into from
May 12, 2025

Conversation

mattkjames7
Copy link
Contributor

@mattkjames7 mattkjames7 commented May 9, 2025

  • Change the values files with the IDs
  • Try making chown non-breaking for memgraph and mage containers (the recursive chown without lost+found dir)
  • Remove the core dump claim name check introduced under Add core dumps PVC #141 -> I left this the same because that pattern was in the standalone memgraph values from before -> should be done under a different PR

@gitbuda
Copy link
Member

gitbuda commented May 10, 2025

I'm thinking 🤔 the user/group id change under memgraph/memgraph is breaking under docker/k8s deployments wanting to upgrade on top of the existing memgraph directories? It's possible to make the migration here (after we merge #141, I removed recursion under chown, some version of that has to be back)? The plain Docker case is not covered (that's not part of this PR)?

@as51340
Copy link
Collaborator

as51340 commented May 12, 2025

I'm thinking 🤔 the user/group id change under memgraph/memgraph is breaking under docker/k8s deployments wanting to upgrade on top of the existing memgraph directories? It's possible to make the migration here (after we merge #141, I removed recursion under chown, some version of that has to be back)? The plain Docker case is not covered (that's not part of this PR)?

Wrote the same thing on the PR. Users will have to do helm uninstall and then helm install

@gitbuda
Copy link
Member

gitbuda commented May 12, 2025

@mattkjames7 wait with merging this because I think we should change the chown part ⏳ I'll ping back when ready 😃

@gitbuda
Copy link
Member

gitbuda commented May 12, 2025

The current approach will work, take a look at the following example:
Screenshot 2025-05-12 at 6 09 27 PM
-> find + chown without -R FTW 🚀

@mattkjames7 mattkjames7 merged commit 7520f7e into main May 12, 2025
4 checks passed
@gitbuda gitbuda deleted the bump-3.2.1-version branch May 16, 2025 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants