Use isnan instead of isnanf #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manpage for math.h notes: https://linux.die.net/man/3/isnanf "Note that these functions are obsolete. C99 defines macros isfinite(), isinf(), and isnan() (for all types) replacing them." The C standard documentation here omits isnanf: https://en.cppreference.com/w/c/header/math And it seems that many downstream implementations (especially ones for platforms other than Linux) leave it out.
|
@memononen I know that you asked me to change some code from |
|
I did not realize it was a macro! lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manpage for math.h notes:
https://linux.die.net/man/3/isnanf
"Note that these functions are obsolete. C99 defines macros isfinite(), isinf(), and isnan() (for all types) replacing them."
The C standard documentation here omits isnanf:
https://en.cppreference.com/w/c/header/math
And it seems that many downstream implementations (especially ones for platforms other than Linux) leave it out.