Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itx.rs: Unsafe cleanup #836

Closed
5 tasks
Tracked by #835
randomPoison opened this issue Mar 18, 2024 · 1 comment
Closed
5 tasks
Tracked by #835

itx.rs: Unsafe cleanup #836

randomPoison opened this issue Mar 18, 2024 · 1 comment
Assignees
@thedataking @kkysen

Comments

@randomPoison
Copy link
Collaborator

randomPoison commented Mar 18, 2024 •
edited
Loading

There are ~2000 unsafe operations being performed in itx.rs (currently split between itx_tmpl_16.rs and itx_tmpl_8.rs, #683 should be merged before working on this task).

  • Cleanup unsafe operations happening within functions.
  • Mark any functions that can be made fully safe as such.
  • Add unsafe blocks around any remaining unsafe operations along with standard safety documentation.
  • Add safety documentation for functions that need to remain unsafe.
  • Add #![deny(unsafe_op_in_unsafe_fn)] to file.
@randomPoison randomPoison mentioned this issue Mar 18, 2024
Closed
21 tasks
@randomPoison randomPoison changed the title src/itx_tmpl_16.rs : 2090 itx.rs: Safety cleanup pass Mar 18, 2024
@randomPoison randomPoison changed the title itx.rs: Safety cleanup pass itx.rs: Unsafe cleanup Mar 18, 2024
@thedataking thedataking self-assigned this Mar 21, 2024
@kkysen kkysen self-assigned this May 6, 2024
This was referenced May 7, 2024
Merged
Merged
kkysen added a commit that referenced this issue May 7, 2024
@kkysen
fn inv_txfm_add_rust: Cleanup and make mostly safe (#1041)
c1ab115 
* Fixes `fn inv_txfm_add_rust` of #817.
* Fixes `fn inv_txfm_add_rust` of #836.
kkysen added a commit that referenced this issue May 7, 2024
@kkysen
fn inv_txfm_add_wht_wht_4x4_rust: Cleanup and make mostly safe (#1042)
a09bda1 
* Fixes `fn inv_txfm_add_wht_wht_4x4_rust` of #817.
* Fixes `fn inv_txfm_add_wht_wht_4x4_rust` of #836.

Very similar to #1041.
@randomPoison
Copy link
Collaborator Author

Done as of #1143.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedataking thedataking

@kkysen kkysen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@randomPoison @thedataking @kkysen