Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fn inv_txfm_add_rust: Cleanup and make mostly safe #1041

Merged
merged 18 commits into from
May 7, 2024
Merged

fn inv_txfm_add_rust: Cleanup and make mostly safe #1041

merged 18 commits into from
May 7, 2024

Conversation

kkysen
Copy link
Collaborator

@kkysen kkysen commented May 7, 2024

@kkysen kkysen requested a review from randomPoison May 7, 2024 01:40
@kkysen kkysen mentioned this pull request May 7, 2024
Merged
@kkysen kkysen force-pushed the kkysen/fn-inv_txfm_add_rust-cleanup branch from 8f7da91 to ae7768e Compare May 7, 2024 02:13
kkysen added 18 commits May 7, 2024 11:46
@kkysen
fn inv_txfm_add_rust: Remove Option from the fn ptr args.
acdc6a7
@kkysen
fn inv_txfm_add_rust: Translate assert!s.
4811378
@kkysen
fn inv_txfm_add_rust: Remove _[0-9]+ var suffixes.
c38922f
@kkysen
fn inv_txfm_add_rust: Add back line breaks from C.
d113f17
@kkysen
fn inv_txfm_add_rust: Remove redundant as casts.
d99e405
@kkysen
fn inv_txfm_add_rust: Remove redundant type annotations.
eafb6ce
@kkysen
fn inv_txfm_add_rust: Remove fresh[0-9]+ temp vars.
624a15e
@kkysen
fn inv_txfm_add_rust: Make is_rect2 var a bool.
11ff04a
@kkysen
fn inv_txfm_add_rust: Make coeff a slice based on accessed length.
20a6b4e
@kkysen
fn inv_txfm_add_rust: Make c var a slice.
fd83092
@kkysen
type itx_1d_fn: Name args in fn ptr.
8a78419
@kkysen
fn inv_txfm_add_rust: Allow stride to be negative again.
09612e1
@kkysen
fn inv_txfm_add_rust: Translate for loops.
a3e2062
@kkysen
fn inv_txfm_add_rust: Made w, h args const generics (fn is no…
756dfad 
…t `#[inline(never)]`).
@kkysen
fn inv_txfm_add_rust: Make shift arg a const generic.
7676b5b
@kkysen
fn inv_txfm_add_rust: Make has_dconly arg a const generic.
66c1cbc
@kkysen
fn inv_txfm_add_rust: Remove redundant as usize casts.
ac8c9c7
@kkysen
fn inv_txfm_add_rust: Redeclare c var as an immut slice when reused.
f6e6691
@kkysen kkysen force-pushed the kkysen/fn-inv_txfm_add_rust-cleanup branch from ae7768e to f6e6691 Compare May 7, 2024 18:51
@kkysen kkysen merged commit c1ab115 into main May 7, 2024
21 checks passed
@kkysen kkysen deleted the kkysen/fn-inv_txfm_add_rust-cleanup branch May 7, 2024 18:55
kkysen added a commit that referenced this pull request May 7, 2024
@kkysen
fn inv_txfm_add_wht_wht_4x4_rust: Cleanup and make mostly safe (#1042)
a09bda1 
* Fixes `fn inv_txfm_add_wht_wht_4x4_rust` of #817.
* Fixes `fn inv_txfm_add_wht_wht_4x4_rust` of #836.

Very similar to #1041.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomPoison randomPoison randomPoison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kkysen @randomPoison