Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum InterIntraType: make a real enum #832

Merged
merged 3 commits into from
Mar 19, 2024
Merged

enum InterIntraType: make a real enum #832

merged 3 commits into from
Mar 19, 2024

Conversation

folkertdev
Copy link
Collaborator

No description provided.

kkysen
kkysen approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@kkysen kkysen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since the changes all LGTM, but you could try implementing the Option version I suggested, too.

src/decode.rs Outdated Show resolved Hide resolved
src/levels.rs Outdated Show resolved Hide resolved
kkysen
kkysen approved these changes Mar 19, 2024
View reviewed changes
src/decode.rs Outdated Show resolved Hide resolved
@kkysen kkysen merged commit 1b75449 into main Mar 19, 2024
35 checks passed
@kkysen kkysen deleted the inter-intra-type-enum branch March 19, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkysen kkysen kkysen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@folkertdev @kkysen