Merged
Conversation
This change prevents us from generating function declarations for non-existent assembly routines.
randomPoison
approved these changes
Mar 22, 2024
Collaborator
randomPoison
left a comment
randomPoison
left a comment
There was a problem hiding this comment.
Ah cool, I was hoping your bpc_fn! approach could be used to fix the dead code elimination requirement. Looks good to me!
Collaborator
|
Oh, I already had a mostly complete fix for this from a while ago that I was waiting on #683 to finish. This change itself looks good, though, so it's good enough probably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enum BPCdepends onopt-level >= 1to dead-code eliminate asmfns #614.Fixes situations where debug builds wouldn't link without dead code elimination and resets debug builds to the defaults.