Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial rate limiting impl based on the leaky-bucket and concread crates #67

Merged
merged 23 commits into from
Aug 29, 2024

Conversation

jamesmunns
Copy link
Collaborator

No description provided.

@jamesmunns jamesmunns marked this pull request as ready for review August 28, 2024 15:42
@jamesmunns
Copy link
Collaborator Author

This is now generally complete, waiting for feedback on docs, and I'll plan to merge this.

CC udoprog/leaky-bucket#34 for notes regarding the "token debt" optimization necessary in the future.

Copy link
Contributor

@branlwyd branlwyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wordsmithing things, and a couple of implementation questions.

user-manual/src/config/kdl.md Outdated Show resolved Hide resolved
user-manual/src/config/kdl.md Outdated Show resolved Hide resolved
user-manual/src/config/kdl.md Outdated Show resolved Hide resolved
user-manual/src/config/kdl.md Outdated Show resolved Hide resolved
user-manual/src/config/kdl.md Show resolved Hide resolved
user-manual/src/config/kdl.md Show resolved Hide resolved
user-manual/src/config/kdl.md Show resolved Hide resolved
user-manual/src/config/kdl.md Show resolved Hide resolved
@jamesmunns jamesmunns merged commit ab3bfb5 into main Aug 29, 2024
6 checks passed
@jamesmunns jamesmunns deleted the james/rate-limiting branch August 29, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants