Add Traditional Chinese (zh_tw) language support #5313
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to e3644f2 in 1 minute and 46 seconds. Click for details.
- Reviewed
123lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/i18n.ts:42
- Draft comment:
It appears that for the 'zh_tw' language, the 'common' key is assigned to 'zhTwChat'. This looks like a copy-paste error. Should it be 'zhTwCommon' instead? - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_ZbVUEzzQTHUMnv11
You can customize 
|
Thanks @YC815 for the contribution, we will take a look and merge soon. |
|
I saw the pull request "Enhance i18n and add missing i18n for all components #5314." Once that pull request is merged, I can update this one to be compatible. |
|
Hi @YC815 FYI, the Enhance 18n... PR has been merged |
There was a problem hiding this comment.
Pull Request Overview
This PR adds Traditional Chinese (zh_tw) language support to the web application's internationalization system. The implementation includes translation files for all namespaces and proper integration into the language switching functionality.
- Added Traditional Chinese translations for chat, common, and settings namespaces
- Integrated
zh_twinto the i18n configuration and language switcher - Followed existing pattern for language support implementation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
web-app/src/locales/zh_tw/settings.json |
Added Traditional Chinese translations for settings interface |
web-app/src/locales/zh_tw/common.json |
Added Traditional Chinese translations for common UI elements |
web-app/src/locales/zh_tw/chat.json |
Added Traditional Chinese translations for chat interface |
web-app/src/i18n.ts |
Registered zh_tw namespace imports and configuration |
web-app/src/containers/LanguageSwitcher.tsx |
Added Traditional Chinese option to language selector |
Comments suppressed due to low confidence (1)
| @@ -12,6 +12,8 @@ const LANGUAGES = [ | |||
| { value: 'en', label: 'English' }, | |||
| { value: 'id', label: 'Bahasa' }, | |||
| { value: 'vn', label: 'Tiếng Việt' }, | |||
| { value: 'zh_tw', label: '繁體中文' | |||
There was a problem hiding this comment.
Missing comma after the object. This inconsistent formatting could cause issues if additional languages are added later.
| { value: 'zh_tw', label: '繁體中文' | |
| { value: 'zh_tw', label: '繁體中文' }, |
Copilot uses AI. Check for mistakes.
| @@ -34,6 +37,11 @@ i18n.use(initReactI18next).init({ | |||
| common: vnCommon, | |||
| settings: vnSettings, | |||
| }, | |||
| zh_tw:{ | |||
There was a problem hiding this comment.
[nitpick] Missing space after colon. Should be zh_tw: { to maintain consistent formatting with other language entries.
| zh_tw:{ | |
| zh_tw: { |
Copilot uses AI. Check for mistakes.
📝 Describe Your Changes
zh_twto the language switcher (LanguageSwitcher.tsx)chat,common, andsettingszh_twnamespace in the i18n initialization (i18n.ts)🛠️ Fixes Issues
🔍 Self Checklist
💡 Notes
This is a simple addition of Traditional Chinese language support. Since the changes are straightforward and self-contained (mostly JSON content and one-line registration edits), I did not check the items in the checklist above. No complex logic was involved.
Important
Add Traditional Chinese (
zh_tw) language support with new translation files and i18n integration.zh_twtoLANGUAGESinLanguageSwitcher.tsx.zh_twtranslations ini18n.tsforchat,common, andsettings.zh_tw/chat.jsonfor chat translations.zh_tw/common.jsonfor common translations.zh_tw/settings.jsonfor settings translations.This description was created by
for e3644f2. You can customize this summary. It will automatically update as commits are pushed.