Fix return value and only set m_swapIntervalConfigured if eglSwapInterval() succeeds #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch from #18 introduced a bug that doesn't return a value in the
makeCurrent()function anymore. Also, setm_swapIntervalConfiguredtofalsein caseeglSwapInterval()fails, so we can try setting the swap interval again at next try.Hopefully this doesn't result in a situation where it tries to set the swap interval, but always fails, so it tries to set the swap interval on every
makeCurrent(). If this is an issue, we could introduce some maximum number of tries and stop trying to set the interval if it still fails after that.