Skip to content

gha: make MaxConcurrentReconciles for each reconciler configurable #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tfujiwar
Copy link
Collaborator

@tfujiwar tfujiwar commented Nov 19, 2024

WHAT

  • Update the controller to make MaxConcurrentReconciles configurable.
  • Update the helm chart so that users can specify those values.

WHY

We are hitting the performance limit of the single-threaded reconciliation loop of the controller. We'd like to try increasing the concurrency.

@tfujiwar tfujiwar force-pushed the tfujiwar-configurable-max-concurrent-reconciles branch 2 times, most recently from 9245d57 to 8e824ca Compare November 19, 2024 08:04
@tfujiwar tfujiwar force-pushed the tfujiwar-configurable-max-concurrent-reconciles branch from 8e824ca to 7ca5b32 Compare November 19, 2024 08:45
@tfujiwar tfujiwar marked this pull request as ready for review November 19, 2024 09:39
@tfujiwar tfujiwar self-assigned this Nov 19, 2024
Copy link

@djahandarie djahandarie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@michaelfindlater michaelfindlater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tfujiwar tfujiwar merged commit 057a1e7 into mercari-master Nov 20, 2024
9 checks passed
@tfujiwar tfujiwar deleted the tfujiwar-configurable-max-concurrent-reconciles branch November 20, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants