init commit for scheduled scaling #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@randytqwjp You have to run |
sanposhiho
reviewed
Feb 28, 2024
Comment on lines
+99
to
+113
| type ScheduledScaling struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
|
||
| Spec ScheduledScalingSpec `json:"spec,omitempty"` | ||
| Status ScheduledScalingStatus `json:"status,omitempty"` | ||
| } | ||
|
|
||
| //+kubebuilder:object:root=true | ||
|
|
||
| // ScheduledScalingList contains a list of ScheduledScaling | ||
| type ScheduledScalingList struct { | ||
| metav1.TypeMeta `json:",inline"` | ||
| metav1.ListMeta `json:"metadata,omitempty"` | ||
| Items []ScheduledScaling `json:"items"` |
Collaborator
Author
There was a problem hiding this comment.
protobuf is missing in tortoise_types.go as well
sanposhiho
reviewed
Feb 28, 2024
sanposhiho
reviewed
Mar 5, 2024
sanposhiho
reviewed
Mar 5, 2024
sanposhiho
reviewed
Mar 7, 2024
| // start of schedule | ||
| StartAt *string `json:"startAt,omitempty" protobuf:"bytes,1,opt,name=startAt"` | ||
| // end of schedule | ||
| FinishAt *string `json:"finishAt,omitempty" protobuf:"bytes,2,name=finishAt"` |
Collaborator
There was a problem hiding this comment.
As proposal describes, it should be a required value. We don't want to allow users to keep increasing the resources.
# Must not empty. If empty, the validation webhook rejects the creation.
https://github.com/mercari/tortoise/blob/main/proposals/scheduled-scaling/README.md
sanposhiho
reviewed
Apr 23, 2024
| // start of schedule | ||
| StartAt *string `json:"startAt,omitempty" protobuf:"bytes,1,name=startAt"` | ||
| // end of schedule | ||
| FinishAt *string `json:"finishAt,omitempty" protobuf:"bytes,2,name=finishAt"` |
Collaborator
There was a problem hiding this comment.
Suggested change
| FinishAt *string `json:"finishAt,omitempty" protobuf:"bytes,2,name=finishAt"` | |
| FinishAt *string `json:"finishAt" protobuf:"bytes,2,name=finishAt"` |
sanposhiho
reviewed
Apr 26, 2024
Collaborator
sanposhiho
left a comment
sanposhiho
left a comment
There was a problem hiding this comment.
Also, you have to make manifests after updating api/v1alpha1/scheduledscaling_types.go so that all CRD spec is updated accordingly
| type Schedule struct { | ||
| /// RFC3339 format e.g., "2006-01-02T15:04:05Z09:00" | ||
| // start of schedule | ||
| StartAt *string `json:"startAt" protobuf:"bytes,1,name=startAt"` |
Collaborator
There was a problem hiding this comment.
StartAt is required.
Suggested change
| StartAt *string `json:"startAt" protobuf:"bytes,1,name=startAt"` | |
| StartAt *string `json:"startAt,omitempty" protobuf:"bytes,1,opt,name=startAt"` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Create CRD for scheduledscaling
Which issue(s) this PR fixes:
#34
Fixes #
Special notes for your reviewer: