Skip to content

Introduce multiple service group categories and maximumMaxReplicas for each of them #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Introduce multiple service group categories and maximumMaxReplicas for each of them #428

wants to merge 9 commits into from

Conversation

AVSBharadwaj
Copy link
Collaborator

@AVSBharadwaj AVSBharadwaj commented Jan 9, 2025 •
edited
Loading

code Implementation of this Issue: #426

Introduces:

  • feature for introducing multiple categories of service types ( like default, fintech-service, critical-service, etc
  • feature for having multiple maximumMaxReplicas value one for each of the service-categories mentioned above

@AVSBharadwaj AVSBharadwaj mentioned this pull request Jan 9, 2025
Open
sanposhiho
sanposhiho reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review path

sanposhiho
sanposhiho reviewed Jan 15, 2025
View reviewed changes
sanposhiho
sanposhiho reviewed Jan 16, 2025
View reviewed changes
@AVSBharadwaj AVSBharadwaj force-pushed the multiple-service-groups-feature branch from 343c435 to 00134fe Compare January 21, 2025 09:37
@AVSBharadwaj AVSBharadwaj force-pushed the multiple-service-groups-feature branch from d6b89b9 to c15336c Compare January 22, 2025 01:17
sanposhiho
sanposhiho reviewed Jan 22, 2025
View reviewed changes
@AVSBharadwaj AVSBharadwaj force-pushed the multiple-service-groups-feature branch from 1f5489f to ec73edc Compare June 20, 2025 07:25
@AVSBharadwaj AVSBharadwaj force-pushed the multiple-service-groups-feature branch from ec73edc to 44f709d Compare June 20, 2025 07:40
@AVSBharadwaj AVSBharadwaj requested a review from sanposhiho July 2, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randytqwjp randytqwjp Awaiting requested review from randytqwjp randytqwjp is a code owner

@jrbangit jrbangit Awaiting requested review from jrbangit jrbangit is a code owner

@AdityaK011 AdityaK011 Awaiting requested review from AdityaK011 AdityaK011 is a code owner

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AVSBharadwaj @sanposhiho