Fix/kustomize issues 435 440 #449
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix deprecated patchesStrategicMerge syntax by removing 'path:' prefix - Update all kustomization.yaml files to include proper apiVersion and kind - Replace deprecated 'vars' with modern 'replacements' syntax - Resolve service name conflict between controller-manager-metrics-service - Remove reference to missing manager_metrics_patch.yaml file - Add validate-kustomize target to Makefile for syntax validation - Update install and deploy targets to include validation step Fixes issues mercari#435 and mercari#440 related to kustomize errors during installation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
The dist/ directory contains generated installation files created by make build-installer and should not be committed to version control. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
anridig
requested review from
randytqwjp,
AVSBharadwaj,
jrbangit and
AdityaK011
as code owners
|
There's always a possibility that Claude Code misunderstood something very fundamental about the codebase, so this PR needs to be thoroughly reviewed by a maintainer ❗ |
|
There was a similar fix PR raised by JR : #439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims to fix issues #435 and #440
✅ Key Fixes Applied:
✅ Files Modified: