Iconify support second try #1731
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaidjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Iconify support added to the live editor.
Resolves #1566
📏 Design Decisions
In config tab you have this by default.
{ "theme": "dark" }Now you can add your icons from iconify like this.
{ "theme": "dark" "icons" : { "name": "npm package" } }Using the example from architecture docs your config should be:
{ "theme": "dark", "icons": { "logos": "@iconify-json/logos" } }The icons are downloaded from unpkg url, just like the docs.
📋 Tasks
Make sure you
developbranchAdditional notes
I already tried to add icons using an extension a long time ago. Now I have tried directly using the live editor.
There is some small issue in the editor, that it tells you that "icons" is not a property from MermaidConfig (which is true) and rn idk how to solve, but I would like some feedback from devs for this.