refactor: migrate to React #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/components/DiagramFrame/SeqDiagram/LifeLineLayer/LifeLine.tsx
Dismissed
Show dismissed
Hide dismissed
dyon21
force-pushed
the
feat/react
branch
2 times, most recently
from
7c9351a to
ac68ee0
Compare
dyon21
force-pushed
the
feat/react
branch
2 times, most recently
from
6bdaacc to
721f0cb
Compare
dontry
reviewed
Jun 3, 2025
dontry
reviewed
Jun 7, 2025
| @@ -62,14 +66,7 @@ | |||
| } | |||
| </style> | |||
| </head> | |||
|
|
|||
| <body> | |||
There was a problem hiding this comment.
I think we can still keep this section
| pnpm-lcok.yaml |
There was a problem hiding this comment.
Is it a typo? Should it be pnpm-lock.yaml?
| fireEvent.click( | ||
| participantWrapper.container.querySelector(".participant")!, | ||
| ); | ||
| // TODO: we need to be able to verify that the computed property `selected` is true |
There was a problem hiding this comment.
Is this comment still relevant?
| const BuildTime = import.meta.env.BUILD_TIME || ""; | ||
| const VueSequence = { | ||
| Vue, |
There was a problem hiding this comment.
Need to change the name VueSequence as well
| import Block from "./components/DiagramFrame/SeqDiagram/MessageLayer/Block/Block.vue"; | ||
| // @ts-ignore | ||
| import Comment from "./components/DiagramFrame/SeqDiagram/MessageLayer/Block/Statement/Comment/Comment.vue"; | ||
| // import Block from "./components/DiagramFrame/SeqDiagram/MessageLayer/Block/Block.vue"; |
| @@ -1,17 +0,0 @@ | |||
| <template> | |||
There was a problem hiding this comment.
Can we turn DiagramTitle/index.tsx to DiagramTitle.tsx?
| @@ -0,0 +1,20 @@ | |||
| import Icon from "@/components/Icon/Icons"; | |||
There was a problem hiding this comment.
Can we turn Privacy/index.tsx to Privacy.tsx?
| SeqDiagram, | ||
| DiagramFrame, | ||
| store, | ||
| // SeqDiagram, |
There was a problem hiding this comment.
Why are they commented out?
| setIsOpen(true); | ||
| }, 0); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Does it need an empty dependency list?
|
|
||
| it("should have a width", async () => { | ||
| expect(messageLayer.container.querySelector(".message-layer")).toBeTruthy(); | ||
| // We do not need to wait until next tick in **test**. |
There was a problem hiding this comment.
nit: remove unrelated comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrate the render library from vuejs to reactjs