Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 19.73% 19.32% -0.42%
==========================================
Files 46 47 +1
Lines 4677 4912 +235
Branches 1083 1158 +75
==========================================
+ Hits 923 949 +26
- Misses 3367 3565 +198
- Partials 387 398 +11
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP and IPv6 support still need to be added (AFAICT my ISP doesn't support IPv6 so I can't really test it even if I added support). TCP was giving me issues so I have decided to shelve it for now (we can probably just open an issue so someone can come along and work on it later).
There are some FIXMEs and such still in the code that I haven't yet gotten around to fixing. Several are regarding output formatting (like what to do when the first connection times out by the second connection attempt to the same hop succeeds), but one or two involve malformed packets.