Persist favourites on NodeDB reset

[ford-jones]

Resolves: #8226
Introduces the option to preserve favourited nodes following a reset of the NodeDB.

Does this by default for nodes set to ROUTER, ROUTER_LATE or CLIENT_BASE.

Protobuf changes: meshtastic/protobufs#791

🤝 Attestations

• I have tested that my proposed changes behave as described.
• I have tested that my proposed changes do not cause any obvious regressions on the following devices:
  • Heltec (Lora32) V3
  • LilyGo T-Deck
  • RAK WisBlock 4631
  • Seeed XIAO NRF52840 / wio-sx-1262

[shalberd]

Does this by default for nodes set to ROUTER, ROUTER_LATE or CLIENT_BASE.

I think having this option across the board, e.g. also for Client and Client_Mute Nodes, would be nice.

The reason there is different on e.h. nrf52 based devices: favoriting certain other mesh nodes on my client or client_mute type node keeps them from being moved off the node DB when there are a large number of nodes, say 300, as we have in Switzerland. Giving them a persistency during operations that I would like to maintain, at least optionally, after a node DB reset, or even a factory reset, for that matter.
So it'd be great if I could keep my favorites as well on Client and Client_Mute device role nodes.
Currently, I am exporting my favorite nodes node by node via a QR code and then re-import them (Android, 2.7 Firmware, 2.7.1 app version).

Thank you for working on this feature.

[shalberd]

persisting / preserving nodes set to be ignored / on the ignore list for rebroadcast would be great feature, too, especially for ROUTER, ROUTER_LATE, CLIENT_BASE, but that is something for a different story :-)

[ford-jones]

I think having this option across the board, e.g. also for Client and Client_Mute Nodes, would be nice.

@shalberd If you check out the protobuf, I created an option for doing precicely that. I.e. config.device.preserve_favourites. This would allow you to persist them through a NodeDB reset even as a CLIENT or any other role.

I like @thebentern's idea though, having this as an additional optional parameter for reset-nodedb.

[shalberd]

I like @thebentern's idea though, having this as an additional optional parameter for reset-nodedb.

Yes, me, too