-
Notifications
You must be signed in to change notification settings - Fork 204
Mute: channels #769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Mute: channels #769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2025
…obufs into 7943-mute-target
This was referenced Sep 16, 2025
… 7943-mute-target
…obufs into 7943-mute-target
fifieldt
approved these changes
Sep 26, 2025
Member
|
This is clean, fixes a real-world feedback report, and has been subject to detailed discussion with Garth, looks safe to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds mute settings for channels.
Note that that the new
channel_settings.muteproperty serves a different purpose tochannel_settings.module_settings.is_client_mutedwhich is used to toggle notifications in the client application(s).Firmware changes: meshtastic/firmware#7957
Docs: meshtastic/meshtastic#2028
Related issues:
meshtastic/device-ui#189
meshtastic/firmware#7943
Checklist before merging