-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/browser setup #205
base: master
Are you sure you want to change the base?
Test/browser setup #205
Conversation
I did have the image snapshots added
but when pushing to my fork I got the message
When looking for the cause or a needed setting I found
git-lfs/git-lfs#1906 (comment) The image snapshots could be useful for documentation purposes in addition to quick visual change checks, but with this restriction by GitHub could be an impediment to contributors? |
the test file is an example, does not test this project in any way, and will be removed as tests for this project are written and the example is no longer needed
Before moving this PR to a ready state we might need to think through the impact of GitHub's image storage on contributions? I'm in the Meshtastic Discord "server" if that helps \m/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this example file before moving the PR to ready for review 🫡
I noticed there were no automated tests. I'd wager it is probably effective to start with browser testing than unit tests in the event of some implementation refactoring. This is a setup with Playwright, with the start of some tests. I can continue to expand the tests if this approach is desirable, or change course based on maintainer feedback 👍