Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MQTT settings #252

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Fix MQTT settings #252

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
283f548
add optional to publishIntervalSecs and positionPrecision
Hunter275 Jun 23, 2024
a5a37cd
update setWorkingModuleConfig to include mapReportSettings
Hunter275 Jun 23, 2024
29fab4b
Merge branch 'master' into issue-251-mqtt-saving
Hunter275 Jun 24, 2024
205c9a2
Merge branch 'master' into issue-251-mqtt-saving
Hunter275 Jun 25, 2024
2f37390
Linting
Hunter275 Jun 25, 2024
c47aeb6
Merge branch 'issue-251-mqtt-saving' of https://github.com/Hunter275/…
Hunter275 Jun 25, 2024
22c862f
revert package.json
Hunter275 Jun 25, 2024
723c9ee
vercel fix
Hunter275 Jun 25, 2024
fdbcdd9
vercel fix v2
Hunter275 Jun 25, 2024
8893a19
ignore vercel.json in biome
Hunter275 Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/PageComponents/ModuleConfig/MQTT.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,10 @@ export const MQTT = (): JSX.Element => {
new Protobuf.ModuleConfig.ModuleConfig({
payloadVariant: {
case: "mqtt",
value: data,
value: {
...data,
mapReportSettings: new Protobuf.ModuleConfig.ModuleConfig_MapReportSettings(data.mapReportSettings)
},
},
}),
);
Expand Down
4 changes: 3 additions & 1 deletion src/validation/moduleConfig/mqtt.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Message } from "@bufbuild/protobuf";
import type { Protobuf } from "@meshtastic/js";
import { IsBoolean, IsString, Length, IsNumber } from "class-validator";
import { IsBoolean, IsString, Length, IsNumber, IsOptional } from "class-validator";

export class MqttValidation
implements
Expand Down Expand Up @@ -47,8 +47,10 @@ export class MqttValidationMapReportSettings
Omit<Protobuf.ModuleConfig.ModuleConfig_MapReportSettings, keyof Message>
{
@IsNumber()
@IsOptional()
publishIntervalSecs: number;

@IsNumber()
@IsOptional()
positionPrecision: number;
}