fix: improve styling of messages #390
Conversation
danditomaso
commented
Jan 29, 2025
danditomaso
commented
- Modified message layout to improve alignment of Avatar and longName
- Maintained existing message styling and state indicators (ack, waiting, error)
- Improved alignment of message text to long name
|
Can you add before/after screenshots? How does it look on mobile screens? |
danditomaso
changed the title
|
@Hunter275 Let me know if there are any concerns with this PR, we should get it merged before issuing a new release to fix some avatar alignment issues. |
|
The background on the selected page is being shortened
|
|
Nice touch would be to show tool tip when hovering over the status. "waiting for acknowledgment", "delivered"... Like on mobile. |
I like this idea, but you cant use a hover state on mobile browser. :( |
|
@dzienisz What do you think of this? When you hover your mouse over the delivery icon you'll get the status of the message.
|
|
If we removed the Traceroute feature, is the user able to do that in another place now? |
|
Can we decrease the spacing between the Node name and the message? Also I really like the color transition from the ACK but I'm not a fan of the
It might work to use the pipe as the visual component for the ACK. It starts yellow and transitions to green after the ACK. 
|
I like this! With these kind of features, we always need to watch what users think about it and iterate over it. Otherwise, it's good to have some UX/UI person onboard. I feel that this iteration is a good move forward, but I would spend some time in the future to work more on this. It's a critical place in application as this is the place where people communicate with each other. |
Great question. I don't know yet enough about it. Maybe @danditomaso could help us? |
|
@Hunter275 @dzienisz, traceroute will be added into nodes pages. With #307 PR. |
That has been fixed in this PR, not sure when this regression was introduced. We absolutely need ui testing to ensure these types of changes are preventing from being introduced going forwards. |
|
@KomelT @dzienisz Traceroute was removed from the DM Message Going forwards I can absolutely see having these tools grouped in Messages inside some sort of "Actions" dropdown, to avoid cluttering the toolbar. Also I would love to have a UI/UX designer available, but since we're all volunteers its up to use to use our respective skillsets to contribute code, I come from a UI/UX background as I have been a frontend dev for 5+ years now, but wouldn't call myself a designer |
@Hunter275 I can make those changes this morning. So i'm decreasing the space each message/message group takes up, and removing the pipe, or having it change change color based on the status of the message |
|
I think some UX/UI designers could volunteer, but we should actively look for them. Software is not just backend but also frontend 😅 |
If you know anyone please have them help out, but in the mean time I come from a frontend dev background, which is why I have been contributing so many PR's to this specific repo. |
|
@danditomaso I think leaving it with the font color is best. That's what other apps are doing. Is there a font color for items that failed to ACK? |
There currently isn't but I can add one. Do you like red or would you prefer like a shade of grey be used? |
|
@Hunter275 Alright, I've made the changes you requested please see the screenshots. The error state A conversation |
