Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add MultiSelect component #394

Merged
merged 3 commits into from
Feb 8, 2025

Conversation

danditomaso
Copy link
Collaborator

@danditomaso danditomaso commented Jan 31, 2025

  • Created reusable MultiSelect checkbox component
    image
    image

  • Created custom hook to manage position flag state (usePositionFlags)

  • Internal flag state management with computed activeFlags

  • Type-safe flag manipulation (toggleFlag, setFlag, setFlags)

Fixes #305

@danditomaso danditomaso requested a review from Hunter275 January 31, 2025 21:13
@danditomaso danditomaso changed the title Feat: Add reusable MultiSelect checkbox component Feat: Add MultiSelect component Jan 31, 2025
@Hunter275
Copy link
Member

Is there somewhere that explains what these mean?

@Hunter275 Hunter275 added enhancement New feature or request minor change This is a minor change parity Feature is in other app (iOS, Android, etc) labels Jan 31, 2025
@danditomaso
Copy link
Collaborator Author

Is there somewhere that explains what these mean?

That's a good point. There is this on the Meshtastic website (https://meshtastic.org/docs/configuration/radio/position/#position-flags) which does a decent job explaining it. Do you think we should add an info icon or the hyperlink into the description?

@Hunter275
Copy link
Member

@danditomaso a link to that page would work or a dialog in case no Internet

@danditomaso
Copy link
Collaborator Author

danditomaso commented Feb 2, 2025

@Hunter275 Still planning on adding a dialog to provide contextual help, but I looked at Android and IOS and found neither app provides further help on what these flags mean, should we raise that to those teams to add in order to have parity between apps?

@danditomaso danditomaso marked this pull request as draft February 4, 2025 03:30
@danditomaso danditomaso marked this pull request as ready for review February 7, 2025 16:09
@danditomaso danditomaso requested review from Hunter275 and removed request for Hunter275 February 7, 2025 19:27
@Hunter275 Hunter275 merged commit b706792 into meshtastic:master Feb 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor change This is a minor change parity Feature is in other app (iOS, Android, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiselect for Position Flags is broken
2 participants