Updated nginx config to pass sub directories #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danditomaso
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR improves route handling for single-page applications in the Nginx configuration and aligns CI workflows with their intended triggers and cache scopes.
- Updated Nginx
try_filesto serveindex.htmlfor subdirectory routes. - Renamed the PR workflow and switched its trigger to
pull_request. - Adjusted Deno cache path and key in the CI workflow to point to the
packages/weblock file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/web/infra/default.conf | Updated try_files to fallback to /index.html for unmatched routes |
| .github/workflows/pr.yml | Renamed workflow to “Pull Requests CI” and changed trigger to pull_request |
| .github/workflows/ci.yml | Pointed cache path and hash key to packages/web/deno.lock |
Comments suppressed due to low confidence (2)
.github/workflows/pr.yml:3
- The original push trigger for the main branch was removed, so CI will no longer run on direct pushes to
main. Confirm this change is intentional or consider re-adding thepushevent to maintain builds on main.
on: pull_request
.github/workflows/ci.yml:32
- There is a trailing whitespace after
packages/web/deno.lockwhich may prevent the cache path from matching correctly. Please remove the extra space.
packages/web/deno.lock
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danditomaso
added a commit
to danditomaso/meshtastic-web
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Web Server Configuration:
This pull request includes updates to CI workflows and a configuration change in the web server. The most important changes involve modifying the workflows to better align with their purposes and improving the handling of routes in the web server configuration.
Related Issues
Changes Made
try_filesdirective to fall back to/index.htmlfor unmatched routes, improving support for single-page applications.Testing Done
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)