update pr workflow #697
Merged
update pr workflow #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the CI workflow and changes its trigger to run on pull requests instead of pushes to main.
- Renamed workflow from “Push to Main CI” to “Pull Request CI”
- Replaced
pushtrigger onmainbranch with apull_requestevent - Kept existing permissions configuration
Comments suppressed due to low confidence (1)
.github/workflows/pr.yml:3
- [nitpick] Consider narrowing the
pull_requesttrigger to specific branches or event types (e.g.,types: [opened, synchronize]) to reduce unnecessary CI runs.
on: pull_request
danditomaso
added a commit
to danditomaso/meshtastic-web
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Changes Made
Testing Done
Screenshots (if applicable)
Checklist
CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)