-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: skip setting rpath if it's not needed #139
Conversation
4285ccb
to
049b439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b7eec3b
to
eab0888
Compare
Ugh, this still depends on other fixes:
That's because the test package it's built on is still xfailed: @pytest.mark.xfail(reason='Meson bug')
def test_purelib_and_platlib(wheel_purelib_and_platlib):
artifact = wheel.wheelfile.WheelFile(wheel_purelib_and_platlib)
expecting = {
f'plat{EXT_SUFFIX}', This passes locally with Meson master. After the other open PR for tags is merged, it should pass with released Meson as well. |
1e3b333
to
10d2095
Compare
Signed-off-by: Filipe Laíns <[email protected]>
e30111c
to
914c1f4
Compare
As per https://github.com/FFY00/meson-python/pull/143#issuecomment-1261084168, I rebased this PR on |
914c1f4
to
167d25e
Compare
You just lost the commits that made this PR pass CI. I'll re-add them. |
167d25e
to
adda659
Compare
Yeah, sorry, they got lost in the rebase. I have just added the fixes directly to the affected commits. |
Sorry 😅 |
adda659
to
c342874
Compare
I think that's it, but hard to be sure since I had to manually re-apply fixes. Let's first ensure CI is green, and then if desired at the end rewrite history to the desired commit granularity. |
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
Signed-off-by: Filipe Laíns <[email protected]>
This allows figuring out what went wrong, in case there is an issue. Signed-off-by: Filipe Laíns <[email protected]>
I have squashed the fix with the affected commit, the tests seem to be passing, are you okay with me pushing? |
Sure, go ahead. CI is green (codecov isn't relevant, and Sage isn't currently testing the right thing). So rewrite history as you wish and then merge it I'd say. |
101991a
to
b7d251a
Compare
I also fixed
ELF.rpath
, which is needed for the tests, and added a test for setting the rpath in the first place in this PR.Fixes #125